Recently, I've just joined a terrible project that former members (most of them are now at other projects or packing things to leave the company) should shame on them.
Everything is messy at the project. Spec? No one knows the spec. What the client feels right at the moment is the spec. Schedule? Changes easily and never shared. Budget? I don't even want to know that.
Nothing seems right here but the stupidest thing was found at everywhere in the code.
return awesomeUrl + "?foo=bar";
This is it. I found almost 100 of this. I don't know why they think it's good enough but I have 3 things to say to them.
1. URLs are not Strings
First of all, URLs are not Strings. Your abstraction is totally wrong.
Are you trying to say that each member of awesomeUrl.split("/"), that type is String[], is a URL? http://example.com/awesome/resources/1?foo=bar?foo=bar?foo=bar is a valid URL? Use java.net.URI instead.
2. It doesn't work
You won't believe it, but it's IMPORTANT to make your code work right.
Since we're using Seasar2 framework that consumes redirect=true from redirect URL, Some of the code work right. Browsers won't understand such stupid strings.
3. Burn in Hell
Long live so-called web developers! You are too cool to learn even the basic things.